Skip to content

HHH-19697 Use case-insensitive Dialect query pattern matching #10702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dnovitski
Copy link

@dnovitski dnovitski commented Aug 6, 2025

The query pattern used in Dialect is case sensitive and it currently only allows lower case queries. This PR adds support to allow uppercase (SELECT .. FROM .. WHERE) by making the query pattern regex case insensitive.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19697

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Aug 6, 2025

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@dnovitski
Copy link
Author

I tried to create a ticket on JIRA but could not log in; I hope this is OK

@marko-bekhta
Copy link
Member

thanks for the patch.

I tried to create a ticket on JIRA but could not log in; I hope this is OK

Does this help: #hibernate-user > ✔ JIRA Login not possible?
or which problem with the login have you encountered?

@dnovitski
Copy link
Author

dnovitski commented Aug 6, 2025

thanks for the patch.

I tried to create a ticket on JIRA but could not log in; I hope this is OK

Does this help: #hibernate-user > ✔ JIRA Login not possible? or which problem with the login have you encountered?

When I press the login button as mentioned, I get redirected back to the same page and still not logged in. When I go to atlassian home my user is logged in. It's something specific to the hibernate atlassian project. When I try via incognito mode, I get the pop up to log in; But when my login succeeds, I get redirected back again and still appear as not logged in.

@dnovitski dnovitski force-pushed the dialect_case_insensitive_query_pattern branch from 01bd055 to eabc8a0 Compare August 8, 2025 08:32
@dnovitski
Copy link
Author

I've created a new Jira account with my ISP email address; This was successful and I managed to create a Jira ticket. I've modified the commit message to add the Jira ticket number

@dnovitski dnovitski requested a review from gavinking August 8, 2025 11:00
@dnovitski dnovitski force-pushed the dialect_case_insensitive_query_pattern branch from e0f67a2 to dbbe1db Compare August 8, 2025 15:31
@dnovitski dnovitski changed the title Use case-insensitive Dialect query pattern matching HHH-19697 Use case-insensitive Dialect query pattern matching Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants